fix: fix links error when using GitHub Enterprise #2350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goatwu1993
changed the title
|
@chingor13 please take a look? |
chingor13
requested changes
Sep 11, 2024
src/util/github-server.ts
Outdated
| @@ -0,0 +1 @@ | |||
| export const DEFAULT_GITHUB_SERVER_URL = process.env.GITHUB_SERVER_URL || 'https://github.com'; | |||
There was a problem hiding this comment.
We would like any environment variable handling to happen at the entrypoint of running release-please and injecting the configuration into the classes rather than pulling from the environment in various spots.
In this case, can we configure/pull this from the GitHub class?
There was a problem hiding this comment.
maybe this should not happend in release-please but only in release-please-action while merging default...
Pjrich1313
approved these changes
Oct 1, 2024
|
@chingor13 updated. please review again NOTE: this has some duplication with the input changelog host and i am not sure if these two inputs changelog-host & server-url should be aliased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
With this update, while release-please/release-please-actions runs in GitHub Enterprise actions/workflow, the links by default is correct.
Fixes #2351 🦕